[PATCH] D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 16:20:29 PDT 2021


zequanwu added a comment.

In D104272#2820587 <https://reviews.llvm.org/D104272#2820587>, @dblaikie wrote:

>> The patch looks mostly good, but I'm not sold on "op". Can we just use "p"?
>
> Presumably then we wouldn't know whether to parse a type after the address space or not? Unless we only support this when everything is opaque pointers? (so there can be no confusion between opaque pointers or not)

It seems what's after "{intrinsic}." is not important for IR parsing: https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/IntrinsicInst.cpp#L127.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104272/new/

https://reviews.llvm.org/D104272



More information about the llvm-commits mailing list