[PATCH] D104272: [OpaquePtr] Mangle intrinsics with opaque pointers arguments

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D104272#2820587 <https://reviews.llvm.org/D104272#2820587>, @dblaikie wrote:

>> The patch looks mostly good, but I'm not sold on "op". Can we just use "p"?
>
> Presumably then we wouldn't know whether to parse a type after the address space or not? Unless we only support this when everything is opaque pointers? (so there can be no confusion between opaque pointers or not)

IIUC, we don't really care about the exact name, just that it doesn't conflict with another declaration of the same intrinsic but with different parameter types. This is unambiguous even when non-opaque pointers are in the picture, since non-opaque pointers will always have something after the `p0`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104272/new/

https://reviews.llvm.org/D104272