[PATCH] D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections

Sriraman Tallam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 11:32:15 PDT 2021


tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2949
+  // non-primary basic block sections are not contiguous with primary basic
+  // block sectoin, don't emit relocation for non-prmiary (and non-contiguous)
+  // basic block sections.
----------------
Typo, "section" and "primary".  Similar comment rnk at .  The condition below only checks whether it is not the entry block but the comment says it is all non-primary basic blocks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101421/new/

https://reviews.llvm.org/D101421



More information about the llvm-commits mailing list