[PATCH] D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 11:21:34 PDT 2021


rnk added a comment.

Sorry for the delay.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2952
+  if (MI->getParent()->getParent()->hasBBSections() &&
+      !MI->getParent()->isEntryBlock())
+    return;
----------------
Instead of just the entry block, can this be `MI->getParent()->getSectionID() == MBBSectionId::Default`? That would cover all blocks in the default section, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101421/new/

https://reviews.llvm.org/D101421



More information about the llvm-commits mailing list