[PATCH] D104264: Fix atomic loads and stores of 64-bit values in non-default address spaces on ARM

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 10:36:21 PDT 2021


arsenm added a comment.

In D104264#2819660 <https://reviews.llvm.org/D104264#2819660>, @rengolin wrote:

> In D104264#2819465 <https://reviews.llvm.org/D104264#2819465>, @koutheir wrote:
>
>> If I understand well, you rather opt for choice `(2)`: Atomic loads and stores are legal only on the default address space.
>
> Not quite. Address spaces in LLVM are a somewhat opaque concept, and can mean anything. I'm just not sure they are exchangeable like you propose on all cases.

They are target defined. You're only doing this for this one target, so you can make them mean whatever you want them to mean


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104264/new/

https://reviews.llvm.org/D104264



More information about the llvm-commits mailing list