[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

> As far as I understand, your CustomBehaviour plus the RetireOOO change does improve the AMDGPU simulation.
> @foad, what do you think about it?
>
> Basically, if the AMDGPU changes are a good improvement, then I still think that it makes sense to keep them as part of the patch.

The AMDGPU improvements are nice (thanks!) but there is a fair bit of code to review in AMDGPUCustomBehaviour.cpp, so I would prefer that all the AMDGPU parts were split out into a separate patch for ease of review. In particular I don't like working around the lack of flags on Real DS instructions; I would much rather fix that properly.

But if you really want to commit this patch as-is and then review and fix the AMDGPU parts later then I won't block it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149