[PATCH] D104149: [MCA] Adding the CustomBehaviour class to llvm-mca

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

The patch looks good to me.
I have requested to commit the changes to the RegisterFile as a follow-up. I'd like to keep those changes separate from this initial patch (see my comment below).

Also, please wait for the feedback from @foad about the changes/improvements to the AMDGPU model.

P.s.: The issue with the extra definition of register `M0` has been fixed by commit `beb5213a2ee5: [MCA][InstrBuilder] Check for the presence of flag VariadicOpsAreDefs.`.

Thanks
-Andrea



================
Comment at: llvm/lib/MCA/HardwareUnits/RegisterFile.cpp:325-328
+  // If RegID is 0, it means we removed this Def in post processing.
+  if (!RegID)
+    return;
+
----------------
In one of my previous messages, I've explicitly asked to send this particular change in a follow-up patch.

If possible, I'd like to keep this change separate from the rest of the work on the CustomBehaviour class. It is fine if there are no tests for it. Also, you don't need to send another patch for review just for this extra register checks. You can simply commit it straight away in main as soon as the rest of this patch is in main too.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104149/new/

https://reviews.llvm.org/D104149