[PATCH] D104205: [X86] Schedule-model second (mask) output of GATHER instruction

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

@RKSimon thank you for the review!



================
Comment at: llvm/lib/Target/X86/X86Schedule.td:128
 def WriteMove    : SchedWrite;
+def WriteGatherMaskWriteback : SchedWrite;
 def WriteCopy    : WriteSequence<[WriteLoad, WriteStore]>; // mem->mem copy
----------------
RKSimon wrote:
> RKSimon wrote:
> > Maybe call this WriteVecMaskedGather to more closely match the other vector load/store classes? Maybe move it to be with the WriteVecMaskedLoad defs as well for clarity.
> > 
> > I'm assuming we don't need separate float/integer classes for this?
> OK, very pedantic but maybe call this WriteVecMaskedGatherWriteback so that it matches the naming convention for vector loads and will match if we add masked gather classes in the future (although tbh they are so diverse in characteristic that it might be easier to just use customs).
Yep, thank you for the suggestion, i didn't like the name i came up anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104205/new/

https://reviews.llvm.org/D104205