[PATCH] D104211: [Polly][Isl] Replacing isl method `to_str()` with `stringFromIslObj()`. NFC.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM with one nitpick.

If the forward-declaration is indeed needed for some reason I did not see, commit with it.



================
Comment at: polly/include/polly/Support/GICHelper.h:154-159
+  inline std::string stringFromIslObj(const name &Obj,                         \
+                                      std::string DefaultValue = "");          \
+  inline std::string stringFromIslObj(const name &Obj,                         \
+                                      std::string DefaultValue) {              \
+    return stringFromIslObj(Obj.get(), DefaultValue);                          \
+  }
----------------
Why forward declaring something that is defined on the next line?


================
Comment at: polly/lib/Analysis/ScopInfo.cpp:1239-1244
-  auto *S = getSchedule().release();
-  if (!S)
-    return {};
-  auto Str = stringFromIslObj(S);
-  isl_map_free(S);
-  return Str;
----------------
That was one way to make things complicated ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104211/new/

https://reviews.llvm.org/D104211