[PATCH] D104211: [Polly][Isl] Replacing isl method `to_str()` with `stringFromIslObj()`. NFC.

[Riccardo Mori via Phabricator via llvm-commits]

patacca created this revision.
Herald added a reviewer: bollu.
Herald added subscribers: ormris, steven_wu, hiraditya.
patacca retitled this revision from "[Polly][Isl] Replacing isl method `to_str()` with `stringFromIslObj()`" to "[Polly][Isl] Replacing isl method `to_str()` with `stringFromIslObj()`. NFC.".
patacca edited the summary of this revision.
patacca added a reviewer: Meinersbur.
patacca added a project: Polly.
patacca published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is part of an effort to reduce the differences between the custom C++ bindings used right now by polly in `lib/External/isl/include/isl/isl-noxceptions.h` and the official isl C++ interface.

Changes made:

- Removing method `to_str()` from all the classes in the isl C++ bindings.
- Overload method `stringFromIslObj()` so it accepts isl C++ objects.
- To keep backward compatibility `stringFromIslObj()` now accepts a value that is returned if the isl C object is `null` or doesn't have a string representation (by default it's an empty string). In some cases it's better to have the string "null" instead of an empty string.
- isl-noexceptions.h has been generated by this https://github.com/patacca/isl/commit/d33ec3a3bbaf971b254a853e6d8200ff9f5a1385


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104211

Files:
  polly/include/polly/Support/GICHelper.h
  polly/include/polly/Support/ISLOStream.h
  polly/lib/Analysis/PolyhedralInfo.cpp
  polly/lib/Analysis/ScopBuilder.cpp
  polly/lib/Analysis/ScopInfo.cpp
  polly/lib/CodeGen/IslAst.cpp
  polly/lib/External/isl/include/isl/isl-noexceptions.h
  polly/lib/Support/GICHelper.cpp
  polly/lib/Support/ISLTools.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104211.351807.patch
Type: text/x-patch
Size: 46857 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210614/e9fe0a33/attachment.bin>