[PATCH] D103861: [Attributor] Look through selects in genericValueTraversal

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis accepted this revision.
baziotis added a comment.

Oh, don't mind me, LGTM! 
IMHO, the documentation is fine //if the readier gets some hint that they should look at it// :P Sth like:

  bool BestPossible = !C.hasValue();
  bool SecondBest = isa_and_nonnull<UndefValue>(*C);

might do the trick. Like, they will either get it, or they will see that they don't get it and they'll check the doc. But I don't know if you like the style, maybe too verbose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103861/new/

https://reviews.llvm.org/D103861