[PATCH] D103861: [Attributor] Look through selects in genericValueTraversal
Kuter Dinel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 11 11:50:30 PDT 2021
kuter accepted this revision.
kuter added a comment.
This revision is now accepted and ready to land.
Thanks @jdoerfert for the clarification. I know understand why we are not processing the true and false values there.
The use of Optional in the `A.getAssumedConstant` definitely seems a little counterintuitive. It is documented in the header
but we might also add some comments to the implementation of the function itself.
LGTM if @baziotis doesn't have any concerns.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103861/new/
https://reviews.llvm.org/D103861
More information about the llvm-commits
mailing list