[PATCH] D104075: [ScalarEvolution] Merge howManyGreaterThans with howManyLessThans.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 10:11:17 PDT 2021


efriedma added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:11566
+                  ? getNotSCEV(getSMinExpr(getNotSCEV(RHS), getNotSCEV(Start)))
+                  : getNotSCEV(getUMinExpr(getNotSCEV(RHS), getNotSCEV(Start)));
+      }
----------------
nikic wrote:
> I'm confused by what you're doing here. `getNotSCEV` has a fold that does `~umin(~x, ~y)` to `umax(x, y)`, so the structure you're using here should get undone?
`getNotSCEV(RHS)` and `getNotSCEV(Start)` will likely be simplified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104075/new/

https://reviews.llvm.org/D104075



More information about the llvm-commits mailing list