[PATCH] D104075: [ScalarEvolution] Merge howManyGreaterThans with howManyLessThans.

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Several level of comments.

First, the LT handling is substantially more powerful than the GT handling.  e.g. for unknown strides.  Given that, this is definitely NOT nfc, and should have accompanying test changes.

Second, I'd prefer this not go in until the underlying LT miscompile we've been discussing is addressed.  The GT code handles this case differently, and I'm not sure that pushing GT through this code is safe.

Third, I'd suggest an alternate interface.  Please remove the IsSigned and Invert parameters, and just pass through the condition.  These two properties can be derived inside the method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104075/new/

https://reviews.llvm.org/D104075