[PATCH] D104107: [NFCI][X86] Drop "atom"/"slm" target tuning "features", derive them from CPU string

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:810
   /// TODO: to be removed later and replaced with suitable properties
-  bool isAtom() const { return X86ProcFamily == IntelAtom; }
-  bool isSLM() const { return X86ProcFamily == IntelSLM; }
+  bool isAtom() const { return getTuneCPU() == "atom"; }
+  bool isSLM() const { return getTuneCPU() == "slm"; }
----------------
Don’t we also accept “bonnell”?


================
Comment at: llvm/lib/Target/X86/X86Subtarget.h:811
+  bool isAtom() const { return getTuneCPU() == "atom"; }
+  bool isSLM() const { return getTuneCPU() == "slm"; }
   bool useSoftFloat() const { return UseSoftFloat; }
----------------
Don’t we also accept “silvermont”?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104107/new/

https://reviews.llvm.org/D104107