[PATCH] D104107: [NFCI][X86] Drop "atom"/"slm" target tuning "features", derive them from CPU string
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 11 05:07:32 PDT 2021
lebedev.ri added a comment.
In D104107#2813077 <https://reviews.llvm.org/D104107#2813077>, @RKSimon wrote:
> I've no objections, but really I'd like to see the isAtom() and isSLM() methods removed entirely - both appear to have been added as perf regression hacks over the years, and then reused where proper feature flags should have been added instead.
At least some of their uses are to pick CPU-specific cost model over the generic worst-case one.
I'm not sure if this is something that can be just dropped.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104107/new/
https://reviews.llvm.org/D104107
More information about the llvm-commits
mailing list