[PATCH] D104114: [llvm-symbolizer] improve test and fix doc example after recent --print-source-context-lines behaviour change

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 06:10:31 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.

> Maybe -C/-A/-B are available to match grep because the current option is quite long?

We can't adopt new short options from tools other than GNU addr2line, as the command-line syntax of llvm-symbolizer is intended to be compatible (i.e. all addr2line options should be present in llvm-symbolizer). If addr2line were to add one or more of these options with a different meaning, we'd end up with an incompatibility. Also, -C is already used for symbol demangling.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104114/new/

https://reviews.llvm.org/D104114



More information about the llvm-commits mailing list