[PATCH] D103009: [DSE] Use calloc for memset+malloc

[Dawid Jurczak via Phabricator via llvm-commits]

yurai007 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1822
+                Malloc->replaceAllUsesWith(Calloc);
+                Malloc->eraseFromParent();
+                return true;
----------------
yurai007 wrote:
> nikic wrote:
> > Looks like this doesn't preserve MemorySSA? Try `-passes='dse,verify<memoryssa>'` in the test.
> Will check.
> Looks like this doesn't preserve MemorySSA? Try -passes='dse,verify<memoryssa>' in the test.

Right, missed MemorySSAUpdater. I'm submitting fix + related UT right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103009/new/

https://reviews.llvm.org/D103009