[PATCH] D95789: [SpeculateAroundPHIs] Avoid speculation on loop back edges

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In D95789#2812692 <https://reviews.llvm.org/D95789#2812692>, @nikic wrote:

> It seems like the addition of this pass has been somewhat botched by adding it only to the NewPM pipeline -- for no clear reason I can discern. This was at a time where barely anyone (outside Google) was using the NewPM, which means that this received very little evaluation from other parties. Now people are hitting this as part of the LegacyPM -> NewPM migration instead, which really shouldn't be the case.
>
> It might make sense to remove this pass from the NewPM default pipeline again (or put it behind an option) and then restart the process of enabling it by default, this time with due diligence.

Aha, so i'm not the only one with that sentiment. D104099 <https://reviews.llvm.org/D104099> it is then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95789/new/

https://reviews.llvm.org/D95789