[PATCH] D95789: [SpeculateAroundPHIs] Avoid speculation on loop back edges
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 11 01:54:18 PDT 2021
nikic added a comment.
It seems like the addition of this patch has been somewhat botched by adding it only to the NewPM pipeline -- for no clear reason I can discern. This was at a time where barely anyone (outside Google) was using the NewPM, which means that this received very little evaluation from other parties. Now people are hitting this as part of the LegacyPM -> NewPM migration instead, which really shouldn't be the case.
It might make sense to remove this pass from the NewPM default pipeline again (or put it behind an option) and then restart the process of enabling it by default, this time with due diligence.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95789/new/
https://reviews.llvm.org/D95789
More information about the llvm-commits
mailing list