[PATCH] D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).

[Kevin Athey via Phabricator via llvm-commits]

kda added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_fake_stack.cpp:241
 // ---------------------- Interface ---------------- {{{1
 using namespace __asan;
 #define DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(class_id)                       \
----------------
vitalybuka wrote:
> I asked to remove DEFINE_STACK_MALLOC_ALWAYS_WITH_CLASS_ID and just have:
> 
> ```
> 
> using namespace __asan;
> #define DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(class_id)                       \
>   extern "C" SANITIZER_INTERFACE_ATTRIBUTE uptr                                \
>       __asan_stack_malloc_##class_id(uptr size) {                              \
>     return OnMalloc(class_id, size);                                           \
>   }                                                                            \
>   extern "C" SANITIZER_INTERFACE_ATTRIBUTE void __asan_stack_free_##class_id(  \
>       uptr ptr, uptr size) {                                                   \
>     OnFree(ptr, class_id, size);                                               \
>   }
>   extern "C" SANITIZER_INTERFACE_ATTRIBUTE uptr            \
>       __asan_stack_malloc_always_##class_id(uptr size) {   \
>     return OnMallocAlways(class_id, size);                 \
>   }
> 
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(0)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(1)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(2)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(3)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(4)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(5)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(6)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(7)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(8)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(9)
> DEFINE_STACK_MALLOC_FREE_WITH_CLASS_ID(10)
> 
> 
> ```
Sent https://reviews.llvm.org/D103965.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103304/new/

https://reviews.llvm.org/D103304