[PATCH] D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_fake_stack.cpp:219
 
+ALWAYS_INLINE uptr OnMallocAlways(uptr class_id, uptr size) {
+  FakeStack *fs = GetFakeStackFastAlways();
----------------
vitalybuka wrote:
> kda wrote:
> > vitalybuka wrote:
> > > static ALWAYS_INLINE
> > > siblings as well.
> > Although, with ALWAYS_INLINE, I'm not sure 'static' makes any difference, as the code is already local to the call point.
> with inline it still need needs provide external version of the symbol
with "inline-no-static" it still need needs provide external version of the symbol




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103304/new/

https://reviews.llvm.org/D103304