[PATCH] D93838: [SCCP] Add Function Specialization pass

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 04:01:05 PDT 2021


SjoerdMeijer added a comment.

In D93838#2807515 <https://reviews.llvm.org/D93838#2807515>, @fhahn wrote:

> In D93838#2793238 <https://reviews.llvm.org/D93838#2793238>, @SjoerdMeijer wrote:
>
>> Addressed @fhahn 's comments: don't run the solver for specialised functions  removed the recursive specialization test for now.
>
> I'm not sure if removing the recursive specialization test is the best thing to do, without known what it is supposed to test? If it is a legitimate test, I thin it would be good to keep it.

Thanks for the comments. Since they are minor, I will fix it before committing. I.e., will remove that update to solver and add the test back.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838



More information about the llvm-commits mailing list