[PATCH] D93838: [SCCP] Add Function Specialization pass

Wed Jun 9 02:56:37 PDT 2021

fhahn added a comment.

In D93838#2793238 <https://reviews.llvm.org/D93838#2793238>, @SjoerdMeijer wrote:

> Addressed @fhahn 's comments: don't run the solver for specialised functions  removed the recursive specialization test for now.

I'm not sure if removing the recursive specialization test is the best thing to do, without known what it is supposed to test? If it is a legitimate test, I thin it would be good to keep it.

================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:117
+          !SpecializedFunc->hasFnAttribute(Attribute::Naked))
+        Solver.addTrackedFunction(SpecializedFunc);
+
----------------
Are those updates to the solver still needed, after not running the solver after `specializeFunctions`?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838