[PATCH] D102437: [LV] NFC: Decouple foldTailByMasking from isScalarWithPredication.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 9 02:43:17 PDT 2021


SjoerdMeijer added a comment.

Hmm, strange some comments went missing when I pushed the button previously.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:1343
+
+bool LoopVectorizationLegality::requiresPredicatedWidening(
+    Instruction *I, bool VFIterationIsPredicated) const {
----------------
I think this is related to the legal vs. cost-model discussion. I agree that it is probably more a cost-model thing. Does that mean this needs to live in CostModel, where it used to live?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102437/new/

https://reviews.llvm.org/D102437



More information about the llvm-commits mailing list