[PATCH] D102437: [LV] NFC: Decouple foldTailByMasking from isScalarWithPredication.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:1354
+  case Instruction::Store:
+    // Some instructions can be speculated, even when predication is used
+    // for the block.
----------------
Just wanted to check what we mean by speculation here (or why it is relevant here)?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1517
-  /// instructions that may divide by zero.
-  /// If a non-zero VF has been calculated, we check if I will be scalarized
-  /// predication for that VF.
----------------
nit: `I` -> `\p I`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102437/new/

https://reviews.llvm.org/D102437