[compiler-rt] 11ad9e3 - [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb

[David Spickett via llvm-commits]

Author: David Spickett
Date: 2021-06-09T08:50:21Z
New Revision: 11ad9e31eb3b11d8996c31084c617245b5af1b87

URL: https://github.com/llvm/llvm-project/commit/11ad9e31eb3b11d8996c31084c617245b5af1b87
DIFF: https://github.com/llvm/llvm-project/commit/11ad9e31eb3b11d8996c31084c617245b5af1b87.diff

LOG: [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb

The new test `symbolize_stack_fp.cpp` added in
https://reviews.llvm.org/D102046 assumes that
we can fall back to the fast unwinder.

This is not the case for Thumb and the test is currently
failing on our v7 thumb bot:
https://lab.llvm.org/buildbot/#/builders/26/builds/2096

Skip the test if we're building for a Thumb target.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D103512

Added: 
    

Modified: 
    compiler-rt/test/sanitizer_common/TestCases/Linux/symbolize_stack_fp.cpp
    compiler-rt/test/sanitizer_common/lit.common.cfg.py
    compiler-rt/test/sanitizer_common/lit.site.cfg.py.in

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/sanitizer_common/TestCases/Linux/symbolize_stack_fp.cpp b/compiler-rt/test/sanitizer_common/TestCases/Linux/symbolize_stack_fp.cpp
index 0d798a9cc15f5..8d9dad1c9ac90 100644
--- a/compiler-rt/test/sanitizer_common/TestCases/Linux/symbolize_stack_fp.cpp
+++ b/compiler-rt/test/sanitizer_common/TestCases/Linux/symbolize_stack_fp.cpp
@@ -7,6 +7,9 @@
 // On android %t is a wrapper python script so llvm-readelf will fail.
 // UNSUPPORTED: android
 
+/// Fast unwinder does not work with Thumb code
+// UNSUPPORTED: thumb
+
 /// No .eh_frame && -g => .debug_frame
 // SEC: .debug_frame
 

diff  --git a/compiler-rt/test/sanitizer_common/lit.common.cfg.py b/compiler-rt/test/sanitizer_common/lit.common.cfg.py
index b4f0670f99594..110314bbb4bdf 100644
--- a/compiler-rt/test/sanitizer_common/lit.common.cfg.py
+++ b/compiler-rt/test/sanitizer_common/lit.common.cfg.py
@@ -31,6 +31,9 @@
 if config.host_os == 'Linux' and config.tool_name == "lsan" and config.target_arch == 'i386':
   config.available_features.add("lsan-x86")
 
+if config.arm_thumb:
+  config.available_features.add('thumb')
+
 if config.host_os == 'Darwin':
   # On Darwin, we default to `abort_on_error=1`, which would make tests run
   # much slower. Let's override this and run lit tests with 'abort_on_error=0'.

diff  --git a/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in b/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in
index 38f5ca1584631..e2db9482f9164 100644
--- a/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in
+++ b/compiler-rt/test/sanitizer_common/lit.site.cfg.py.in
@@ -6,6 +6,8 @@ config.tool_name = "@SANITIZER_COMMON_LIT_TEST_MODE@"
 config.target_cflags = "@SANITIZER_COMMON_TEST_TARGET_CFLAGS@"
 config.target_arch = "@SANITIZER_COMMON_TEST_TARGET_ARCH@"
 
+config.arm_thumb = "@COMPILER_RT_ARM_THUMB@"
+
 # Load common config for all compiler-rt lit tests.
 lit_config.load_config(config, "@COMPILER_RT_BINARY_DIR@/test/lit.common.configured")