[PATCH] D103786: [AIX][compiler-rt] Fix cmake build of libatomic for cmake-3.16+

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:16
+    set(${link_flags}
+      "-Wl,-G -Wl,-H512 -Wl,-D0 \
+       -Wl,-T512 -Wl,-bhalt:4 -Wl,-bernotok \
----------------
Can we move the common flags up and add `-Wl, -G` only  > 3.16?


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:771
     set(BUILTIN_DEPS builtins)
+    get_aix_libatomic_type(BUILTIN_TYPE)
   endif()
----------------
Add comments about why we need to update BUILTIN_TYPE here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103786/new/

https://reviews.llvm.org/D103786