[PATCH] D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 21:07:10 PDT 2021


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1326
+  // sp -= gap;
+  // When HasBP && isPPC64, we have r0, r1, r12, r30 available and r1 is already
+  // copied to r30 which is BPReg. So BPReg stores the value of back-chain
----------------
jsji wrote:
> Reorg this comment please. HasBP is always true, so this is really the difference for isPPC64 vs isPPC32?
Should be `HasBP && HasRedzone`, I have updated the condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100290/new/

https://reviews.llvm.org/D100290



More information about the llvm-commits mailing list