[PATCH] D100290: [PowerPC] Make sure the first probe is full size or is the last probe when stack is realigned

[Kai Luo via Phabricator via llvm-commits]

lkail marked 8 inline comments as done.
lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1343
+    // FIXME: We only support NegProbeSize materialized by DForm currently.
+    // When HasBP && isPPC64, we should have a idle register to materialize
+    // NegProbeSize to larger values.
----------------
jsji wrote:
> Do you mean we can use xform if we have an additional idle register?
Exactly.


================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:1509
+      // Probe residual part.
+      if (NegResidualSize) {
+        bool ResidualUseDForm = CanUseDForm(NegResidualSize);
----------------
jsji wrote:
> Split change related to this into another patch?
Yes, we can do it later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100290/new/

https://reviews.llvm.org/D100290