[PATCH] D100944: [MC][ELF] Emit separate unique sections for different flags

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

In D100944#2770791 <https://reviews.llvm.org/D100944#2770791>, @peter.smith wrote:

> Thanks very much for working on this. I agree with the approach of putting out a separate section when the flags don't match as this matches the non-lto behaviour when the files are compiled separately.



> @bd1976llvm did the changes to explicit-section-mergeable.ll match your expectations?

Sorry for the late reply. I can confirm that the changes to explicit-section-mergeable.ll LGTM - I also confirmed that it passes my downstream testcases that motivated the original https://reviews.llvm.org/D72194. I think this approach should be fine although there *might* be some fallout e.g. from embedded systems that have very simple linkers/loaders (I have no evidence of this though it's just conjecture). As stated on https://reviews.llvm.org/D72194 I think that sometimes the only thing you can do is make a reasonable change and see what breaks - and this looks reasonable to me :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100944/new/

https://reviews.llvm.org/D100944