[PATCH] D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 16:18:35 PDT 2021


rnk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2947
     return;
+  if (MI->getParent()->isBeginSection() && !MI->getParent()->isEntryBlock())
+    return;
----------------
Please add a comment here.

Also, are you sure this is the right condition? Aren't there MBBs that do not begin sections but belong to a non-primary section?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101421/new/

https://reviews.llvm.org/D101421



More information about the llvm-commits mailing list