[PATCH] D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections

[TaoPan via Phabricator via llvm-commits]

TaoPan added inline comments.


================
Comment at: llvm/lib/MC/MCStreamer.cpp:328
+  else if (FI->Section != getCurrentSectionOnly())
+    // There are multiple text sections in a function with option
+    // -basic-block-sections, creating a line table for every text secitons of a
----------------
rnk wrote:
> Please make this change in the AsmPrinter, not the assembler. The assembler should still emit an error: if the user directly uses cv_loc directives, the assembler should produce an error. The compiler needs to avoid asking the assembler to do the impossible.
Thanks for your review comments!
I moved change from assembler to AsmPrinter, the new added condition of not emitting location is same as the condition of creating BB section (calling to getSectionForMachineBasicBlock()) in AsmPrinter.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101421/new/

https://reviews.llvm.org/D101421