[PATCH] D103510: [RISCV] Use vmv.v.[v|i] if we know COPY is under the same vl and vtype.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 18:49:05 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:192
+      // For example, vleff has implicit def VL.
+      for (unsigned I = MBBI->getNumExplicitOperands(),
+                    E = MBBI->getNumOperands();
----------------
Can we use MBBI->modifiesRegister(RISCV::VL)?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:366
     if (NF == 1) {
-      BuildMI(MBB, MBBI, DL, get(Opc), DstReg)
-          .addReg(SrcReg, getKillRegState(KillSrc));
+      auto MIB = BuildMI(MBB, MBBI, DL, get(Opc), DstReg);
+      if (UseVMV_V_I)
----------------
I think we need to add the VL and VTYPE implicit uses?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103510/new/

https://reviews.llvm.org/D103510



More information about the llvm-commits mailing list