[PATCH] D103301: [AArch64][GlobalISel] Implement moreElements legalization for G_SHUFFLE_VECTOR.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4848
+    int Idx = Mask[I];
+    if (Idx < (int)NumElts)
+      NewMask.push_back(Idx);
----------------
static cast?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-shuffle-vector-wip.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=aarch64 -O0 -run-pass=legalizer -global-isel-abort=2 %s -o - | FileCheck %s
+# This test runs with -global-isel-abort=2 because we currently don't have support
----------------
-verify-machineinstrs?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/legalize-shuffle-vector-wip.mir:11
+liveins:
+  - { reg: '$d0' }
+  - { reg: '$d1' }
----------------
might as well drop the liveins and other similar cruft?


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:4053
+
+  // Check
+  EXPECT_TRUE(CheckMachineFunction(*MF, CheckStr)) << *MF;
----------------
is this an unfinished comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103301/new/

https://reviews.llvm.org/D103301