[PATCH] D102335: [flang] Move buffer runtime test to GTest

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

Apologies for taking so long to comment!

In D102335#2754515 <https://reviews.llvm.org/D102335#2754515>, @ashermancinelli wrote:

> @awarzynski This is just the minimum to pull the test into gtest. I would like to add documentation and death tests for failure conditions - do you have any suggestions for this? I think once we have those two criteria met we can add more reviewers.

IMHO, this is sufficient. I've tried to produce a death test, but this particular API makes it tricky (i.e. I'm finding it hard to make it crash), which is a good thing!

I'm in favor of merging this as is. The only thing that's missing is the standard LLVM header at the top.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102335/new/

https://reviews.llvm.org/D102335