[PATCH] D103174: RISCV: honour `.option relax` in assembly

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/RISCV/scoped-relaxation.s:3
+
+       .global function
+
----------------
compnerd wrote:
> jrtc27 wrote:
> > Don't indent any of these, it just makes the test look ugly.
> I think that we can disagree then.  I think that it is far more legible than everything being 0-column aligned.  FWIW, most of the other backends do use the indentation (particularly the ones that I've worked with in LLVM in the past - ARM, ARM64, X86, and by extension X86_64).
Personally I keep `.globl`/labels/etc at 0-column (top-level stuff) and `.long`/`.word`/etc at 2-column (function-level stuff).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103174/new/

https://reviews.llvm.org/D103174