[PATCH] D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo()

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 2 09:53:12 PDT 2021


aprantl added inline comments.


================
Comment at: llvm/lib/IR/DebugInfo.cpp:418
+                     [&Visited, &DILocationReachable](const MDOperand &Op) {
+                       return isa<DILocation>(Op.get()) ||
+                              isDILocationReachable(
----------------
vsk wrote:
> Is the `isa<DILocation>(Op.get())` part redundant here, since it should be checked within `isDILocationReachable`?
Yes. I removed them in fcfaed4ae6d7. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103220/new/

https://reviews.llvm.org/D103220



More information about the llvm-commits mailing list