[PATCH] D103220: Support stripping indirectly referenced DILocations from !llvm.loop metadata in stripDebugInfo()

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 2 07:53:56 PDT 2021


vsk added a comment.

Thanks Adrian. + 1 from me as well, FTR.



================
Comment at: llvm/lib/IR/DebugInfo.cpp:418
+                     [&Visited, &DILocationReachable](const MDOperand &Op) {
+                       return isa<DILocation>(Op.get()) ||
+                              isDILocationReachable(
----------------
Is the `isa<DILocation>(Op.get())` part redundant here, since it should be checked within `isDILocationReachable`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103220/new/

https://reviews.llvm.org/D103220



More information about the llvm-commits mailing list