[PATCH] D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode
Yvan Roux via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 2 06:21:12 PDT 2021
yroux added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5987
+ Scale = 1;
+ break;
case ARMII::AddrModeT2_ldrex:
----------------
efriedma wrote:
> Maybe assert "Fixup" is a multiple of 4?
ok, and I'll change the check line 6005 into an assert
================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6001
default:
llvm_unreachable("Unsupported addressing mode!");
}
----------------
chill wrote:
> Can't we instead `return false;` here and get rid of enumerating all unsupported addressing modes on line 5933?
hmm, yes I agree it'll make it easier to read
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103167/new/
https://reviews.llvm.org/D103167
More information about the llvm-commits
mailing list