[PATCH] D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 2 05:53:35 PDT 2021


chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6001
   default:
     llvm_unreachable("Unsupported addressing mode!");
   }
----------------
Can't we instead `return false;` here and get rid of enumerating all unsupported addressing modes on line 5933?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103167/new/

https://reviews.llvm.org/D103167



More information about the llvm-commits mailing list