[PATCH] D103428: [lld/mac] Make -t work correctly with -flat_namespace

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added a comment.

In D103428#2791652 <https://reviews.llvm.org/D103428#2791652>, @int3 wrote:

> Hm, could we not just emit the message inside the DylibFile and ObjFile constructors?

Yes, putting it in the two DylibFile ctors works just as well. It's the same +4 lines, and printing things from a ctor feels a bit weird, so I put it where I put it but if you want I can change it.

> Also nit: Could we have more detail in the commit message? Referencing bugzilla is a bit inconvenient (plus it could get confusing if more comments are left on the issue.)

Sure, adding more details.

> Finally: There are a bunch of things listed in that task as "interesting things to check", not sure if we want to have more tests for those, but your call

Yes, I should add more tests for some of these things, but I think they already work :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103428/new/

https://reviews.llvm.org/D103428