[PATCH] D103428: [lld/mac] Make -t work correctly with -flat_namespace

[Jez Ng via Phabricator via llvm-commits]

int3 added a comment.

Hm, could we not just emit the message inside the DylibFile and ObjFile constructors?

Also nit: Could we have more detail in the commit message? Referencing bugzilla is a bit inconvenient (plus it could get confusing if more comments are left on the issue.)

Finally: There are a bunch of things listed in that task as "interesting things to check", not sure if we want to have more tests for those, but your call



================
Comment at: lld/test/MachO/flat-namespace.s:19
+# RUN:   FileCheck --check-prefix=T %s
+# T: main.o
+# T-NEXT: baz.dylib
----------------
nit: align with `-NEXT:` lines


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103428/new/

https://reviews.llvm.org/D103428