[PATCH] D103177: [flang][driver] Extend the `flang` bash script to act as a driver

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 1 10:49:56 PDT 2021


awarzynski added a comment.

In D103177#2785499 <https://reviews.llvm.org/D103177#2785499>, @Meinersbur wrote:

> A concern that I have is that the bash script will only on platforms that have bash.

Thanks for bringing this up, I share your concerns. Our goal is to get code generation in llvm-project/flang as soon as possible. Once that's available, we shouldn't need this script and I will be very much of favor of removing it. If it offers a functionality that we'll need long-term, then that functionality should be identified and re-implemented in something platform agnostic (e.g. C++ or Python). For me, this patch is here to facilitate the transition from `f18` to `flang-new` as the default driver.

> In D103177#2782881 <https://reviews.llvm.org/D103177#2782881>, @awarzynski wrote:
>
>> Otherwise `flang`, the bash script, duplicates functionality available in `f18.cpp`. The goal is to move that functionality to `flang`.
>
> I think the argument is that f18.cpp will be removed completely, not necessary to remove specific functionality before that.

Yes, that's the end goal. I guess that I'm focusing more on the intermediate steps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103177/new/

https://reviews.llvm.org/D103177



More information about the llvm-commits mailing list