[PATCH] D103427: [X86] Fix handling of maskmovdqu in X32

[Harald van Dijk via Phabricator via llvm-commits]

hvdijk added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSSE.td:4015
+           VEX, VEX_WIG, AdSize64;
+let Uses = [EDI], Predicates = [HasAVX,In64BitMode] in
+def VMASKMOVDQUX32 : VPDI<0xF7, MRMSrcReg, (outs),
----------------
craig.topper wrote:
> Can we make this CodeGenOnly=1 so the disassembler tables don't need to be updated? Especially since there are no dissambler tests in this patch.
We do need that for correct disassembly. It seems like we have rather limited testing of the disassembler in general; I could add a new test specifically for this that only tests these instructions, but if there's some approach that lets us test the disassembler for all (most) instructions in one go that might be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103427/new/

https://reviews.llvm.org/D103427