[PATCH] D103279: [flang][openacc] Enforce restriction on attach and detach variables

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Two nit suggestions/questions.



================
Comment at: flang/lib/Semantics/resolve-directives.cpp:866
+                context_.Say(designator.source,
+                    "Variable `%s` on the %s clause must be a variable or "
+                    "array with the POINTER or ALLOCATABLE attribute"_err_en_US,
----------------
Nit: Would it be better to say the Argument %s instead of Variable %s since variable again occurs in the message?


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:874
+              context_.Say(name.source,
+                  "Variable `%s` on the %s clause must be a variable or "
+                  "array with the POINTER or ALLOCATABLE attribute"_err_en_US,
----------------
Nit: Is there a test that hits this path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103279/new/

https://reviews.llvm.org/D103279