[PATCH] D103315: Add interface to order inlining

[Kazu Hirata via Phabricator via llvm-commits]

kazu added a comment.

I also agree this is in the right direction.  I've left some minor comments.



================
Comment at: llvm/include/llvm/Analysis/InlineOrder.h:38
+  size_t size() override { return Calls.size(); }
+  reference operator[](size_t idx) { return Calls[idx]; }
+  void push_back(const T &Elt) { Calls.push_back(Elt); }
----------------
I would keep this private.  If you need to accommodate functions like erase, just add a method to this class.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:719
+  DefaultInlineOrder Calls;
+  // SmallVector<std::pair<CallBase *, int>, 16> Calls;
 
----------------
I'd remove this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103315/new/

https://reviews.llvm.org/D103315