[PATCH] D103315: Add interface to order inlining
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 28 08:18:25 PDT 2021
mtrofin added a comment.
I believe this is in the right direction.
I recommend informing the nuances of the API by trying first to replace all the uses of Calls (and the adjustment of the index iterating through Calls, line 906)
Please note the linter notes (virtual dtor, etc)
================
Comment at: llvm/include/llvm/Analysis/InlineOrder.h:17
+
+class InlineOrder {
+public:
----------------
Since this is an abstraction meant for the inliner, I'd just define it in Inliner.cpp (i.e. no need for a header)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103315/new/
https://reviews.llvm.org/D103315
More information about the llvm-commits
mailing list