[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Nearly there. Not approving since there's a build error though...



================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:76
+    bool PrevWasContinued = PrevContinuationBits & 0x01;
+    int RecordNum = (I - base()) / GOFF::RecordLength;
+
----------------
Shouldn't this be a `size_t` or similar? It's an offset, and can't be negative.


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:85
+                                    " is not a continuation record but the "
+                                    "preceeding record is continued")
+        return;
----------------
Please make sure you at least build your changes before uploading them...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437