[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records
Yusra Syeda via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 26 20:02:50 PDT 2021
yusra.syeda marked an inline comment as done.
yusra.syeda added inline comments.
================
Comment at: llvm/include/llvm/Object/GOFF.h:84
+
+ static Error getData(const uint8_t *Record, SmallString<256> &CompleteData) {
+ uint16_t Length = getPropertyModuleLength(Record);
----------------
jhenderson wrote:
> There are a number of these clang-tidy complaints, similar to how there were those SmallString complaints before. Would it make sense to move the body of this and similar functions into a cpp? That would avoid needing to include Error.h in this file directly.
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98437/new/
https://reviews.llvm.org/D98437
More information about the llvm-commits
mailing list